[webkit-reviews] review requested: [Bug 23496] execCommand('bold') will remove <b style='font-style:italic'>, it should probably replace it with <span style='font-style:italic' : [Attachment 27306] Fix and test case
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Feb 3 17:51:57 PST 2009
Eric Seidel <eric at webkit.org> has asked for review:
Bug 23496: execCommand('bold') will remove <b style='font-style:italic'>, it
should probably replace it with <span style='font-style:italic'
https://bugs.webkit.org/show_bug.cgi?id=23496
Attachment 27306: Fix and test case
https://bugs.webkit.org/attachment.cgi?id=27306&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
LayoutTests/ChangeLog | 14 +++
.../convert-style-elements-to-spans-expected.txt | 14 +++
.../convert-style-elements-to-spans.html | 13 +++
.../resources/convert-style-elements-to-spans.js | 47 +++++++++++
WebCore/ChangeLog | 40 +++++++++
WebCore/WebCore.xcodeproj/project.pbxproj | 8 ++
WebCore/css/CSSStyleDeclaration.h | 1 +
WebCore/dom/NamedAttrMap.h | 2 +
WebCore/editing/ApplyStyleCommand.cpp | 70 ++++++++++------
WebCore/editing/ApplyStyleCommand.h | 4 +-
WebCore/editing/CompositeEditCommand.cpp | 6 ++
WebCore/editing/CompositeEditCommand.h | 1 +
.../RemoveNodePreservingChildrenCommand.cpp | 3 +-
WebCore/editing/ReplaceNodeWithSpanCommand.cpp | 87 ++++++++++++++++++++
WebCore/editing/ReplaceNodeWithSpanCommand.h | 60 ++++++++++++++
15 files changed, 341 insertions(+), 29 deletions(-)
More information about the webkit-reviews
mailing list