[webkit-reviews] review denied: [Bug 23690] QtWebKit needs a DOM API : [Attachment 27255] Initial version of DOM API

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 3 05:14:42 PST 2009


Simon Hausmann <hausmann at webkit.org> has denied Adam Treat <treat at kde.org>'s
request for review:
Bug 23690: QtWebKit needs a DOM API
https://bugs.webkit.org/show_bug.cgi?id=23690

Attachment 27255: Initial version of DOM API
https://bugs.webkit.org/attachment.cgi?id=27255&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
I would prefer for this code to be developed in a Git branch first before
hitting the SVN trunk.

The patch itself has a couple of coding style problems (for example the brace
for function definitions belongs onto a line of its own) and it would be good
not to have comments like "// end of stuff added buy gen" in the code itself.

Instead it should be a separate patch, to recognize the contribution by a
different author.

That said, let's use this forum or email to discuss the API :).


More information about the webkit-reviews mailing list