[webkit-reviews] review granted: [Bug 23560] Implement SharedTimer on WorkerRunLoop : [Attachment 27135] Updated patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 3 00:57:16 PST 2009


Alexey Proskuryakov <ap at webkit.org> has granted Dmitry Titov
<dimich at chromium.org>'s request for review:
Bug 23560: Implement SharedTimer on WorkerRunLoop
https://bugs.webkit.org/show_bug.cgi?id=23560

Attachment 27135: Updated patch
https://bugs.webkit.org/attachment.cgi?id=27135&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
> +    {}

We usually put braces on separate lines in this context.

> +    bool isActive() { return m_sharedTimerFunction && m_nextFireTime != 0; }


No need for "!= 0" here.

r=me


More information about the webkit-reviews mailing list