[webkit-reviews] review denied: [Bug 23696] CHROMIUM: select element doesn't show new value when focus is switched in onchange event : [Attachment 27262] v1 patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Darin Fisher (:fishd, Google)
<darin at chromium.org>'s request for review:
Bug 23696: CHROMIUM: select element doesn't show new value when focus is
switched in onchange event
https://bugs.webkit.org/show_bug.cgi?id=23696

Attachment 27262: v1 patch
https://bugs.webkit.org/attachment.cgi?id=27262&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
     if (!m_listBox->parent()) {
 366	     // Must get called after we have a client.
 367	     addChild(m_listBox.get());
 368	 }

Why?


Also:
 PopupMenu::~PopupMenu()
 {
     hide();
+    p.popup = 0;
 }

is p.popup a smartpointer?  If so, we should consider using .clear() instead. 
If it's not, I expect we're leaking the PopupContainer.