[webkit-reviews] review granted: [Bug 23653] PopupMenuChromium.h could be cleaned-up : [Attachment 27190] Patch for PopuMenuChromium.[h, cpp]

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Jay Campan <jcampan at google.com>'s
request for review:
Bug 23653: PopupMenuChromium.h could be cleaned-up
https://bugs.webkit.org/show_bug.cgi?id=23653

Attachment 27190: Patch for PopuMenuChromium.[h,cpp]
https://bugs.webkit.org/attachment.cgi?id=27190&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
This looks fine.

 1 2009-01-29  Jay Campan  <set EMAIL_ADDRESS environment variable>

Your EMAIL_ADDRESS is missing.

Wrong spacing:
+static const PopupContainerSettings dropDownSettings = {
+  true, // focusOnShow
+  true, // setTextOnIndexChange
+  true, // acceptOnAbandon
+  false // loopSelectionNavigation
+};

This looks fine.  Can be fixed on commit.