[webkit-reviews] review denied: [Bug 16356] [GTK] Integrate GStreamer video with the graphics backend : [Attachment 26612] Uses enum values and gets rid of fprintfs

[bugzilla-daemon at webkit.org]

Holger Freyther <zecke at selfish.org> has denied Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 16356: [GTK] Integrate GStreamer video with the graphics backend
https://bugs.webkit.org/show_bug.cgi?id=16356

Attachment 26612: Uses enum values and gets rid of fprintfs
https://bugs.webkit.org/attachment.cgi?id=26612&action=review

------- Additional Comments from Holger Freyther <zecke at selfish.org>

> +    // These subtypes are already beeing supported by WebKit itself
> +    HashSet<String>* ignoredApplicationSubtypes = new HashSet<String>;

^^^^^ leak, leak, leak. Just omit the  '*' and the "= new..."

> +    ignoredApplicationSubtypes->add(String("javascript"));

and turn this into ignoredApplicationSubtypes.add.