[webkit-reviews] review requested: [Bug 30883] [Gtk] Implement AtkText for HTML elements which contain text : [Attachment 45696] proposed patch

[bugzilla-daemon at webkit.org]

Joanmarie Diggs <joanmarie.diggs at gmail.com> has asked  for review:
Bug 30883: [Gtk] Implement AtkText for HTML elements which contain text
https://bugs.webkit.org/show_bug.cgi?id=30883

Attachment 45696: proposed patch
https://bugs.webkit.org/attachment.cgi?id=45696&action=review

------- Additional Comments from Joanmarie Diggs <joanmarie.diggs at gmail.com>
This is the bulk of it (and it might be all of it):

* Implements AtkText for HTML elements which contain text
* Eliminates the now-extraneous objects of ROLE_TEXT from the hierarchy
* get_text_{after,at,before}_offset and get_text work as expected
* Layout tests for accessibility are verified to continue to work as expected
* Unit tests for accessibility updated and verified to work as expected

Still on the to-do list:

1. Verify that events work as expected -- and if not, fix that
2. Add a new unit test or two

However as this patch is complete (and MUCH needed and has two bugs now
depending upon it), a review would be most appreciated. Thanks!