[webkit-reviews] review denied: [Bug 33056] Implement NO_RETURN for MSVC : [Attachment 45670] Fix use of NO_RETURN in FastMalloc.cpp
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Dec 30 16:34:23 PST 2009
Mark Rowe (bdash) <mrowe at apple.com> has denied Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 33056: Implement NO_RETURN for MSVC
https://bugs.webkit.org/show_bug.cgi?id=33056
Attachment 45670: Fix use of NO_RETURN in FastMalloc.cpp
https://bugs.webkit.org/attachment.cgi?id=45670&action=review
------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
Given that the function is not intended to return I’m not sure why we’d want to
remove the annotation that indicates that. Anyway, this will break the Mac
build (and possibly others):
JavaScriptCore/wtf/FastMalloc.cpp:1431: warning: function might be possible
candidate for attribute ‘noreturn’
More information about the webkit-reviews
mailing list