[webkit-reviews] review denied: [Bug 32298] Provide Default IWebUIDelegate and IWebFrameLoadDelegate Implementations : [Attachment 44502] default implementation of delegates to reduce boilerplate requirements.

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has denied Brent Fulgham <bfulgham at webkit.org>'s
request for review:
Bug 32298: Provide Default IWebUIDelegate and IWebFrameLoadDelegate
Implementations
https://bugs.webkit.org/show_bug.cgi?id=32298

Attachment 44502: default implementation of delegates to reduce boilerplate
requirements.
https://bugs.webkit.org/attachment.cgi?id=44502&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>

> Index: WebKit/win/WebFrame.cpp
> ===================================================================
> --- WebKit/win/WebFrame.cpp	(revision 51877)
> +++ WebKit/win/WebFrame.cpp	(working copy)
> @@ -986,7 +986,14 @@ HRESULT STDMETHODCALLTYPE WebFrame::sele
>  
>  HRESULT STDMETHODCALLTYPE WebFrame::selectAll()
>  {
> -    return E_NOTIMPL;
> +    Frame* coreFrame = core(this);
> +    if (!coreFrame)
> +	   return E_FAIL;
> +
> +    if (!coreFrame->editor()->command("SelectAll").execute())
> +	   return E_FAIL;
> +
> +    return S_OK;
>  }
>  
>  HRESULT STDMETHODCALLTYPE WebFrame::deselectAll()

I don't believe this was intended to be added.	

Other comments.

Does everything really need to inline?	Should these be inheriting from the
private interfaces as well?