[webkit-reviews] review requested: [Bug 32461] [Qt] Adding QPixmap/QImage support for the Qt hybrid layer : [Attachment 45678] Refactor of hybrid pixmap transferring, with an intermediate object

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam.rosenthal at nokia.com> has asked  for review:
Bug 32461: [Qt] Adding QPixmap/QImage support for the Qt hybrid layer
https://bugs.webkit.org/show_bug.cgi?id=32461

Attachment 45678: Refactor of hybrid pixmap transferring, with an intermediate
object
https://bugs.webkit.org/attachment.cgi?id=45678&action=review

------- Additional Comments from Noam Rosenthal <noam.rosenthal at nokia.com>
Refactored the solution to use an intermediate object (in qt_pixmapruntime.cpp)

- The object has width & height properties, and toHTMLImageElement() and
toDataUrl() functions.
- The Qt bridge still accepts HTMLImageElement directly when sending a pixmap
to Qt, as there's no way to construct this intermediate object, and in this
case there's no implicit creation of DOM elements.
- The intermediate object converts to a QImage/QPixmap when the actual data is
requested: QImage when dataUrl is requested, QPixmap when HTMLImageElement is
requested.

Note that the test still fails the webkit style checker, I already posted a
relevant bug about the style-checker tool.