[webkit-reviews] review denied: [Bug 31887] [Qt] QWebFrame::addToJavaScriptWindowObject() can be used to customize the properties of 'default' JS objects such as 'navigator'. : [Attachment 43867] Patch

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has denied Robert Hogan
<robert at roberthogan.net>'s request for review:
Bug 31887: [Qt] QWebFrame::addToJavaScriptWindowObject() can be used to
customize the properties of 'default' JS objects such as 'navigator'.
https://bugs.webkit.org/show_bug.cgi?id=31887

Attachment 43867: Patch
https://bugs.webkit.org/attachment.cgi?id=43867&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
As discussed on IRC, it would be better to change this test to simply verify
that addToJAvaScriptWindowOBject can replace an replaceable object. The
navigator part is almost overkill :)

+	 Need a short description and bug URL (OOPS!)

This line shouldn't be there :)