[webkit-reviews] review denied: [Bug 32953] [Qt] Qt DRT: respect window.close() and window.closed() : [Attachment 45661] Updated to identify and delete window closed

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has denied Robert Hogan
<robert at roberthogan.net>'s request for review:
Bug 32953: [Qt] Qt DRT: respect window.close() and window.closed()
https://bugs.webkit.org/show_bug.cgi?id=32953

Attachment 45661: Updated to identify and delete window closed
https://bugs.webkit.org/attachment.cgi?id=45661&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>

> +    // It is possible that we get called by windows created from the main
page that have finished
> +    // loading, so we don't ASSERT here. At the moment we do not gather
results from such windows,
> +    // but may need to in future.
> +    if (!(sender() == m_topLoadingFrame->page()))
> +	 return;

The change looks very good to me, but please change the above to use != instead
of !(... == ...) :-)