[webkit-reviews] review canceled: [Bug 33041] [bzt] Speed up CredentialsTest.test_read_credentials_with_SVN to make run-webkit-unittest run faster : [Attachment 45638] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has canceled Daniel Bates
<dbates at webkit.org>'s request for review:
Bug 33041: [bzt] Speed up CredentialsTest.test_read_credentials_with_SVN to
make run-webkit-unittest run faster
https://bugs.webkit.org/show_bug.cgi?id=33041

Attachment 45638: Patch
https://bugs.webkit.org/attachment.cgi?id=45638&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
On second thought, we don't need the optional parameter shouldMakeActualSVNRepo
and related code as it does add much if any value. Original thought was to make
the unit test match the actual environment as close as possible. But it is
sufficient to just create a temporary directory (one in which we know does not
contain a not Git repo).