[webkit-reviews] review requested: [Bug 30389] Input method does not work in Epiphany : [Attachment 45632] gtkim.patch

[bugzilla-daemon at webkit.org]

Duy Nguyen <pclouds at gmail.com> has asked  for review:
Bug 30389: Input method does not work in Epiphany
https://bugs.webkit.org/show_bug.cgi?id=30389

Attachment 45632: gtkim.patch
https://bugs.webkit.org/attachment.cgi?id=45632&action=review

------- Additional Comments from Duy Nguyen <pclouds at gmail.com>
This addresses my last point in the last comment. It seems GtkIMContext can
emit multiple commit and preedit-changed signals in one row.

I tested it with VIQR input method. You can try to type these in GtkLauncher
and a normal GtkEntry to see if the behaviour matches:

aan
bba<move left>d (this does not work correctly due to cursor position, but at
least it does not emit "badba")

My first attempt to make a proper patch, take it easy :)