[webkit-reviews] review denied: [Bug 33012] Marker code is buggy: referencePoint translation is off : [Attachment 45590] Updated patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 29 14:30:44 PST 2009


Dirk Schulze <krit at webkit.org> has denied  review:
Bug 33012: Marker code is buggy: referencePoint translation is off
https://bugs.webkit.org/show_bug.cgi?id=33012

Attachment 45590: Updated patch
https://bugs.webkit.org/attachment.cgi?id=45590&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
The code hits assertions svgElement && svgElement->document() &&
svgElement->isStyled() in RenderPath::calculateMarkerBoundsIfNeeded for the
following tests:
* svg/W3C-SVG-1.1/animate-elem-30-t.svg
* svg/W3C-SVG-1.1/animate-elem-40-t.svg

This LayoutTest needs an upda
* svg/W3C-SVG-1.1/painting-marker-01-f.svg

The feConv test is realy strange. The failure on feConv is realy strange. We
saw it many times before. But my Mac always give me 115 for the text position.
We should figure out why we have the problems with it.


More information about the webkit-reviews mailing list