[webkit-reviews] review denied: [Bug 32991] [Qt] check-webkit-style generates false report on "#include *.moc" : [Attachment 45612] alternative fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 29 11:47:20 PST 2009


Adam Barth <abarth at webkit.org> has denied Chang Shu <Chang.Shu at nokia.com>'s
request for review:
Bug 32991: [Qt] check-webkit-style generates false report on "#include *.moc"
https://bugs.webkit.org/show_bug.cgi?id=32991

Attachment 45612: alternative fix
https://bugs.webkit.org/attachment.cgi?id=45612&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
I'm not a cpp_lint expert, but this second patch looks like a good approach. 
However, we still need a test.	cpp_lint has extensive unit tests.  It should
be straightforward to modify one to test this new behavior.


More information about the webkit-reviews mailing list