[webkit-reviews] review denied: [Bug 33009] Need a script to assign bugs with r+ patches to committers for landing : [Attachment 45587] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 29 11:03:38 PST 2009


Adam Barth <abarth at webkit.org> has denied Eric Seidel <eric at webkit.org>'s
request for review:
Bug 33009: Need a script to assign bugs with r+ patches to committers for
landing
https://bugs.webkit.org/show_bug.cgi?id=33009

Attachment 45587: Patch
https://bugs.webkit.org/attachment.cgi?id=45587&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
+ FIXME: This can be removed once Command understands help_text like
AbstractSequencedCommmand does

You're looking for DeclarativeCommand, which knows how to do this.

+ reviwed_patches

Typo

+ Bug %s likely needs commit-queue

I'd make this a link for easy clickability.

R- because you didn't add any tests!


More information about the webkit-reviews mailing list