[webkit-reviews] review canceled: [Bug 32652] forward-declare libsoup types : [Attachment 45050] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 29 10:54:38 PST 2009


Eric Seidel <eric at webkit.org> has canceled  review:
Bug 32652: forward-declare libsoup types
https://bugs.webkit.org/show_bug.cgi?id=32652

Attachment 45050: patch
https://bugs.webkit.org/attachment.cgi?id=45050&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Yes.  You should feel free to land this once the soup change is in.  You have
both mine and Dave Levin's review for such.

Clearing the r+ for now.  Feel free to mark this r?/cq+ again if you'd prefer
to have the commit-queue land this for you.  If you email me, I'l be happy to
do the official r+ing again at that time.

Unfortunately we don't have an easy way to exclude non-actionable patches form
the pending-commit list.  Adam Barth suggested we create a "CommitBlocked"
keyword, which is one option.  I should probably bring it up on WebKit-dev.


More information about the webkit-reviews mailing list