[webkit-reviews] review denied: [Bug 20736] [GTK] GtkWebKit incompatible with rgba colormaps : [Attachment 45297] Patch for this issue (rev2)

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has denied Martin Robinson
<martin.james.robinson at gmail.com>'s request for review:
Bug 20736: [GTK] GtkWebKit incompatible with rgba colormaps
https://bugs.webkit.org/show_bug.cgi?id=20736

Attachment 45297: Patch for this issue (rev2)
https://bugs.webkit.org/attachment.cgi?id=45297&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
Wicked!

22	   No new tests. (OOPS!)

We should explain here why this isn't testable right now.

5353 #include <string.h>
 54 #include <stdlib.h>

Poorly sorted

 108 static GHashTable *gPartsTable = NULL;
 109 static GtkThemeParts *gParts = NULL;

Bad placement for *'s

 227 gint
 228 moz_gtk_use_parts_for_drawable(GdkDrawable* parts);

gint should be in the same line, in the header file.