[webkit-reviews] review denied: [Bug 32419] Rewrite CSS namespaces layout tests with dumpAsText : [Attachment 44678] Patch v2: moved some files script-tests -> resources

[bugzilla-daemon at webkit.org]

Maciej Stachowiak <mjs at apple.com> has denied Kinuko Yasuda
<kinuko at chromium.org>'s request for review:
Bug 32419: Rewrite CSS namespaces layout tests with dumpAsText
https://bugs.webkit.org/show_bug.cgi?id=32419

Attachment 44678: Patch v2: moved some files script-tests -> resources
https://bugs.webkit.org/attachment.cgi?id=44678&action=review

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
I don't think the new tests are equivalent to the old ones. Here are some
differences:

1) The original tests have the relevant styles inline, not in an external
stylesheets included via ?xml-stylesheet PI.
2) The original tests use elements that are present as markup in the document
as the test subject.
3) Some of the tests had a non-HTML root element and in general a different
tree structure than what your test creates.

All of these changes alter the code paths tested by the tests.

Furthermore, these tests are imported from the official CSS Namespaces test
suite. I don't think we should be making such substantial changes to tests from
an external test suite. I think it would be ok to add the new text-dumping
tests but I do not think the old ones should be removed.