[webkit-reviews] review denied: [Bug 32461] [Qt] Adding QPixmap/QImage support for the Qt hybrid layer : [Attachment 44745] support for QPixmap/QImage handling in QtWebkit hybrid layer, revised with adherence to webkit coding style

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 29 07:42:34 PST 2009


Simon Hausmann <hausmann at webkit.org> has denied Noam Rosenthal
<noam.rosenthal at nokia.com>'s request for review:
Bug 32461: [Qt] Adding QPixmap/QImage support for the Qt hybrid layer
https://bugs.webkit.org/show_bug.cgi?id=32461

Attachment 44745: support for QPixmap/QImage handling in QtWebkit hybrid layer,
revised with adherence to webkit coding style
https://bugs.webkit.org/attachment.cgi?id=44745&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
As convenient as it seems, I'm still worried about extending the DOM API in Qt
with an implicit conversion from a QPixmap to an automatically created DOM
element.

In addition this is limited to HTML image elements, it would not be possible to
use application provided pixmaps for backgrounds for example.

It might be easier to be able to bind pixmaps to a central instance in the API
and get an URI for it, that could be used in anywhere pixmaps/images are
needed.


More information about the webkit-reviews mailing list