[webkit-reviews] review denied: [Bug 32944] HTML5 <header> and <footer> elements support : [Attachment 45553] Proposed patch

[bugzilla-daemon at webkit.org]

Maciej Stachowiak <mjs at apple.com> has denied TAMURA, Kent
<tkent at chromium.org>'s request for review:
Bug 32944: HTML5 <header> and <footer> elements support
https://bugs.webkit.org/show_bug.cgi?id=32944

Attachment 45553: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=45553&action=review

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
(In reply to comment #4)
> (In reply to comment #3)
> > (From update of attachment 45553 [details] [details])
> > Nesting <footer> inside <header> or <footer> (or vive versa) is an
authoring
> > conformance error, but I don't believe it is supposed to result in any
parser
> > error fixup. I do not see any such requirement in the HTML5 parsing
algorithm
> > anyway. r- for now but please resubmit if you can cite a source for that
> > requirement.
> 
>
http://www.whatwg.org/specs/web-apps/current-work/multipage/sections.html#the-h
eader-element
>   4.4.8 The header element
>   ...
>   Content model:
>   Flow content, but with no header or footer element descendants.
> 
>
http://www.whatwg.org/specs/web-apps/current-work/multipage/sections.html#the-f
ooter-element
>   4.4.9 The footer element
>   ...
>   Content model:
>   Flow content, but with no header or footer element descendants.

Those are authoring requirements (i.e. a document violating these is
nonconforming), not implementation requirements (there is no requirement to
enforce these conditions at parse time or otherwise.

The only error corrections that should be done are those required by section
9.2:
http://dev.w3.org/html5/spec/Overview.html#parsing

Please keep this in mind when implementing additional new HTML elements. The
content models in general do *not* result in parser behavior changes.

Please resubmit with the parser changes removed and with correct tests.