[webkit-reviews] review denied: [Bug 32295] Typing in Wave repaints the whole screen : [Attachment 44825] better patch and test

[bugzilla-daemon at webkit.org]

Maciej Stachowiak <mjs at apple.com> has denied James Robinson
<jamesr at chromium.org>'s request for review:
Bug 32295: Typing in Wave repaints the whole screen
https://bugs.webkit.org/show_bug.cgi?id=32295

Attachment 44825: better patch and test
https://bugs.webkit.org/attachment.cgi?id=44825&action=review

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
I suggest editing the CHangeLog to match the standard format. It should be:

    Typing in Wave repaints the whole screen
    https://bugs.webkit.org/show_bug.cgi?id=32295

    Marks a RenderBlock without....

etc rather than putting the big long paragraph first and burying the number.
Also the WebCore ChangeLog says "No new tests" rather than mentioning the new
tests.

Please fix these and resubmit.

For what it's worth: the description of the change sounds sensible to me, but I
can't readily tell if the code change does what the ChangeLog describes.
Hopefully a layout expert can weigh in on that aspect.