[webkit-reviews] review denied: [Bug 32689] Fix the leak of ThreadIdentifiers in threadMap across threads. : [Attachment 45119] Proposed patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 29 04:37:17 PST 2009


Maciej Stachowiak <mjs at apple.com> has denied Dmitry Titov
<dimich at chromium.org>'s request for review:
Bug 32689: Fix the leak of ThreadIdentifiers in threadMap across threads.
https://bugs.webkit.org/show_bug.cgi?id=32689

Attachment 45119: Proposed patch.
https://bugs.webkit.org/attachment.cgi?id=45119&action=review

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
The code change and your explanation look good to me, but is it possible to
provide a test case? It's ok if the test case only fails in debug builds with
the relevant asserts enabled. If it's not possible to create a test case,
please explain why in the ChangeLog.


More information about the webkit-reviews mailing list