[webkit-reviews] review denied: [Bug 32748] Index validation code must always copy client data : [Attachment 45195] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 29 04:34:02 PST 2009


Maciej Stachowiak <mjs at apple.com> has denied Kenneth Russell <kbr at google.com>'s
request for review:
Bug 32748: Index validation code must always copy client data
https://bugs.webkit.org/show_bug.cgi?id=32748

Attachment 45195: Patch
https://bugs.webkit.org/attachment.cgi?id=45195&action=review

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
Code change loks fine, but can you please give the test case a more meaningful
name than "bug-32748"? And could you add a description to the test that
describes what it is actually testing? Maybe this should go in the ChangeLog
too. Basically I'm looking for something that completes the sentence, "Index
validation code must always copy client data, because if it doesn't then
__________".

I will happily r+ this if you can provide that clarification.


More information about the webkit-reviews mailing list