[webkit-reviews] review denied: [Bug 32992] [Qt] fix DRT link failures on --no-svg builds when only making changes to DRT : [Attachment 45572] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 29 00:04:49 PST 2009


Eric Seidel <eric at webkit.org> has denied Robert Hogan
<robert at roberthogan.net>'s request for review:
Bug 32992: [Qt] fix DRT link failures on --no-svg builds when only making
changes to DRT
https://bugs.webkit.org/show_bug.cgi?id=32992

Attachment 45572: Patch
https://bugs.webkit.org/attachment.cgi?id=45572&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
OK.  But SVGSetElement is possibly a bad choice as it would be disabled by
SVG_ANIMATION being off.  SVGDefsElement might be a better choice.

You should also add a comment next to the libraryContainsSymbol call explaining
why you look for SVGDefsElement instead of SVG or SVGElement, etc.


More information about the webkit-reviews mailing list