[webkit-reviews] review denied: [Bug 30435] Update media layout tests to be codec aware and a V8 binding fix. : [Attachment 45448] Round 4
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Dec 28 22:20:32 PST 2009
Eric Seidel <eric at webkit.org> has denied review:
Bug 30435: Update media layout tests to be codec aware and a V8 binding fix.
https://bugs.webkit.org/show_bug.cgi?id=30435
Attachment 45448: Round 4
https://bugs.webkit.org/attachment.cgi?id=45448&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
Changing Maciej's r+ to an r-. This bug is lacking the binary data for the
changed png files, so the commit-queue cannot land it. Andrew is not yet a
committer (according to committers.py), so someone would have to land this for
him. Better would be for Andrew to attach a patch containing the png changes.
"bugzilla-tool post-diff" or "bugzilla-tool post-commits" will handle git
patches correctly. Likewise one could just do a git diff --binary and attach
that.
More information about the webkit-reviews
mailing list