[webkit-reviews] review granted: [Bug 32979] [bzt] Create an ASAD command for uploading a patch : [Attachment 45549] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 32979: [bzt] Create an ASAD command for uploading a patch
https://bugs.webkit.org/show_bug.cgi?id=32979

Attachment 45549: Patch
https://bugs.webkit.org/attachment.cgi?id=45549&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Seems like we'll want some new class for this:
190	    diff = state.get("diff")
 191	     if not diff:
 192		 diff = self._tool.scm().create_patch()
 193		 state["diff"] = diff

Maybe a CachingState?  with a .diff() method?

Or just a .get_cached_value("diff", self._tool.scm().create_patch) command?
Glad to see you've abstracted it at least for this one command.

Looks like an OK start.