[webkit-reviews] review denied: [Bug 32915] valueAsDate setter Part 2: ISODateTime -> String conversion : [Attachment 45462] Proposed patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Dec 28 02:12:59 PST 2009
Maciej Stachowiak <mjs at apple.com> has denied TAMURA, Kent
<tkent at chromium.org>'s request for review:
Bug 32915: valueAsDate setter Part 2: ISODateTime -> String conversion
https://bugs.webkit.org/show_bug.cgi?id=32915
Attachment 45462: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=45462&action=review
------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
This patch lacks tests. Perhaps it is only testable in combination with part 1,
in which case I'd rather see the two combined into one patch with tests
included.
More information about the webkit-reviews
mailing list