[webkit-reviews] review granted: [Bug 32882] Selection-related code needs stricter rules about how it relates to layout : [Attachment 45404] patch

[bugzilla-daemon at webkit.org]

Maciej Stachowiak <mjs at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 32882: Selection-related code needs stricter rules about how it relates to
layout
https://bugs.webkit.org/show_bug.cgi?id=32882

Attachment 45404: patch
https://bugs.webkit.org/attachment.cgi?id=45404&action=review

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
r=me

Potential follow-up:

    // FIXME: Should this set of hasTagName checks be replaced by a
    // virtual member function?

Yes, this should use inheritence somehow insted of tag names. Perhaps autofocus
should always return false and have a virtual override in the classes for those
particular elements.