[webkit-reviews] review denied: [Bug 32602] Add a layout test for Numpad arrow key events : [Attachment 45486] Support key location argument in keyboard event methods for EventSender.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 28 01:52:34 PST 2009


Maciej Stachowiak <mjs at apple.com> has denied Kinuko Yasuda
<kinuko at chromium.org>'s request for review:
Bug 32602: Add a layout test for Numpad arrow key events
https://bugs.webkit.org/show_bug.cgi?id=32602

Attachment 45486: Support key location argument in keyboard event methods for
EventSender.
https://bugs.webkit.org/attachment.cgi?id=45486&action=review

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
Please update the WebCore and WebKit ChangeLog to explain the the apparent
behavior change. If the test will only pass on some platforms, please add it to
the skipped list on other platforms. Please also retitle the bug and its
mention in the ChangeLog to cite the behavior change, not just the added tests.


For example, "Correctly report keyLocation as DOM_KEY_LOCATION_NUMPAD for
numeric pad arrow key events" would be a better explanation.

r- to address these issues.


More information about the webkit-reviews mailing list