[webkit-reviews] review requested: [Bug 32896] [bzt] Bugzilla-tool should not try to get the username and password from Git when we're using SVN : [Attachment 45538] Patch with unit tests

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has asked  for review:
Bug 32896: [bzt] Bugzilla-tool should not try to get the username and password
from Git when we're using SVN
https://bugs.webkit.org/show_bug.cgi?id=32896

Attachment 45538: Patch with unit tests
https://bugs.webkit.org/attachment.cgi?id=45538&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
Notice, calling Git.in_working_directory can throw an OSError errrno 2
exception if the git command is not found because we call Executive.run_command
which does not catch the exception. Hence, this patch modifies
Executive.run_command to catch these exceptions and passes them to the
specified error handler/returns the error code of the exception/returns the
error message of the exception.

For the credentials unit test, I assume SVN is installed as per
<http://webkit.org/building/tools.html> at the time of this writing, since
SVNTestRepository (imported from modules.scm_unittest) assumes it.

Also, I added a new unit test file, executive_unittest.py, to test the change
made to Executive.run_command.