[webkit-reviews] review requested: [Bug 32940] [GTK] Progress notification update taking longer : [Attachment 45500] Changing the download throttle conditions

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 25 15:23:06 PST 2009


Estêvão Samuel Procópio <tevaum at gmail.com> has asked  for review:
Bug 32940: [GTK] Progress notification update taking longer
https://bugs.webkit.org/show_bug.cgi?id=32940

Attachment 45500: Changing the download throttle conditions
https://bugs.webkit.org/attachment.cgi?id=45500&action=review

------- Additional Comments from Estêvão Samuel Procópio <tevaum at gmail.com>
This patch is a proposal for changing the download notification throttle.

The changes are quite simple: 
The code only updates lastElapsed when a progress notification occurs. If we
passed the lastElapsed by more then 0.7 secs from now, we notify again.
I added another static variable, lastNotifiedProgress, that holds the value of
the last notified progress. If we passed more than 1% of the last notified
progress, we notify again.

I must state that this patch is not the final one. I think it's important that
some of you guys try this patch to see if it's good or if we need to think a
better way to do this throttle.


More information about the webkit-reviews mailing list