[webkit-reviews] review granted: [Bug 32938] Cleanup: XSSAuditor passes too many parameters to XSSAuditor::findInRequest : [Attachment 45496] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Dec 25 12:43:53 PST 2009
Adam Barth <abarth at webkit.org> has granted Daniel Bates <dbates at webkit.org>'s
request for review:
Bug 32938: Cleanup: XSSAuditor passes too many parameters to
XSSAuditor::findInRequest
https://bugs.webkit.org/show_bug.cgi?id=32938
Attachment 45496: Patch
https://bugs.webkit.org/attachment.cgi?id=45496&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
This looks great. One nit:
147 task.decodeEntities = true;
You don't need these assignments because decodeEntities defaults to true. We
needed them originally because the parameters were in a fixed order.
Other than that, looks great. Thanks Dan.
More information about the webkit-reviews
mailing list