[webkit-reviews] review granted: [Bug 31665] Web Inspector: Implement the Audits panel : [Attachment 45469] [PATCH] Review comments addressed

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 24 13:27:59 PST 2009


Pavel Feldman <pfeldman at chromium.org> has granted Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 31665: Web Inspector: Implement the Audits panel
https://bugs.webkit.org/show_bug.cgi?id=31665

Attachment 45469: [PATCH] Review comments addressed
https://bugs.webkit.org/attachment.cgi?id=45469&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
The change is quite big, so it is getting hard to re-review it. I am fine with
landing it as is, given the following:

[BUG1]
- Sample audit category (either 'network utilization' or 'page performance') is
getting landed shortly. We need to see how it looks all together.

[BUG2]
- Result view migrates from divs to the treeoutline structure.

[BUG3]
- Double borders are fixed
- All audits get enabled by default
- Results are expanded only one level

Please file corresponding bugs prior to closing this one. (I'll land this one
tomorrow our timezone unless Timothy objects).


More information about the webkit-reviews mailing list