[webkit-reviews] review granted: [Bug 32682] [Qt] webkitdirs.pm function checkFrameworks always die()s with an error under Windows : [Attachment 45108] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Daniel Bates <dbates at webkit.org>'s
request for review:
Bug 32682: [Qt] webkitdirs.pm function checkFrameworks always die()s with an
error under Windows
https://bugs.webkit.org/show_bug.cgi?id=32682

Attachment 45108: Patch
https://bugs.webkit.org/attachment.cgi?id=45108&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
I think the code should have a comment about why we have this.	At some level
the separate -x check isn't even really necessary.  The -e check is most
important.  If somehow someone has their permissions wrong, I'm not sure we
need to catch that here.

I'd just remove the -x check.  Or if you decide to keep it, please add a
comment about why it's separate from the -e check.