[webkit-reviews] review granted: [Bug 32614] [Qt] Memory leak detected in ThreadingQt : [Attachment 45450] fix patch to take care both synchronous and asynchronous mode

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 24 08:54:37 PST 2009


Laszlo Gombos <laszlo.1.gombos at nokia.com> has granted Chang Shu
<Chang.Shu at nokia.com>'s request for review:
Bug 32614: [Qt] Memory leak detected in ThreadingQt
https://bugs.webkit.org/show_bug.cgi?id=32614

Attachment 45450: fix patch to take care both synchronous and asynchronous mode
https://bugs.webkit.org/attachment.cgi?id=45450&action=review

------- Additional Comments from Laszlo Gombos <laszlo.1.gombos at nokia.com>
This looks good to me as detachThread() could be called from any thread
including "self" thread, but the ThreadPrivate destructor is called from the
main application thread.

LGTM, r=me.


More information about the webkit-reviews mailing list