[webkit-reviews] review granted: [Bug 32913] Do not a new Database pointer to any structure until its version has been verified : [Attachment 45458] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Dec 23 17:27:50 PST 2009
Eric Seidel <eric at webkit.org> has granted Dumitru Daniliuc
<dumi at chromium.org>'s request for review:
Bug 32913: Do not a new Database pointer to any structure until its version has
been verified
https://bugs.webkit.org/show_bug.cgi?id=32913
Attachment 45458: patch
https://bugs.webkit.org/attachment.cgi?id=45458&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
Please update the ChangeLog when you land to point out:
1. What test this fixes.
2. What revision caused this regression.
3. That this is in fact a regression fix.
A common way to do that is for the bug title to have REGRESSION(r12345): in it,
and to link to the regrssion commit from the Changelog:
http://trac.webkit.org/changeset/12345
And then just to list the test that it fixes!
I certainly don't need to see this again. :) Thanks for the quick fix!
More information about the webkit-reviews
mailing list