[webkit-reviews] review granted: [Bug 32832] Web Inspector: add Settings.js class that would manage frontend settings. : [Attachment 45340] [PATCH] Proposed fix

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at hatcher.name> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 32832: Web Inspector: add Settings.js class that would manage frontend
settings.
https://bugs.webkit.org/show_bug.cgi?id=32832

Attachment 45340: [PATCH] Proposed fix
https://bugs.webkit.org/attachment.cgi?id=45340&action=review

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
> +	   this._installSetting("eventListenersFilter",
"event-listeners-filter", "all");
> +	   this._installSetting("colorFormat", "color-format", "hex");
> +	   this._installSetting("resourcesLargeRows", "resources-large-rows",
true);
> +	   this._installSetting("watchExpressions", "watch-expressions", []);
> +	   this._installSetting("lastViewedScriptFile",
"last-viewed-script-file");
> +	   this._installSetting("showInheritedComputedStyleProperties",
"show-inherited-computed-style-properties", false);
> +	   this._installSetting("showUserAgentStyles",
"show-user-agent-styles", true);

I think it is weird that this class knows all the settings. I guess these are
default values and like the old Settings object on WebInspector? So I guess it
is the same. Just seemed weird at first…