[webkit-reviews] review granted: [Bug 32592] [check-webkit-style] Refactor cpp_style.parse_arguments so that it has no global variable side effects. : [Attachment 45317] Proposed patch 4
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Dec 23 13:08:23 PST 2009
David Levin <levin at chromium.org> has granted Chris Jerdonek
<chris.jerdonek at gmail.com>'s request for review:
Bug 32592: [check-webkit-style] Refactor cpp_style.parse_arguments so that it
has no global variable side effects.
https://bugs.webkit.org/show_bug.cgi?id=32592
Attachment 45317: Proposed patch 4
https://bugs.webkit.org/attachment.cgi?id=45317&action=review
------- Additional Comments from David Levin <levin at chromium.org>
> Index: ChangeLog
WebKitTools/ChangeLog....
This isn't going to land easily (using cq+) since the patch isn't rooted at
WebKit.
> Index: Scripts/modules/cpp_style.py
> -# This is set by check-webkit-style.
> _USAGE = ''
Is this _USAGE still needed?
More information about the webkit-reviews
mailing list