[webkit-reviews] review canceled: [Bug 32894] [bzt] land-diff shouldn't stat the file system four times : [Attachment 45423] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 23 00:35:13 PST 2009


Adam Barth <abarth at webkit.org> has canceled Adam Barth <abarth at webkit.org>'s
request for review:
Bug 32894: [bzt] land-diff shouldn't stat the file system four times
https://bugs.webkit.org/show_bug.cgi?id=32894

Attachment 45423: Patch
https://bugs.webkit.org/attachment.cgi?id=45423&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
I'm not sure this is the right approach.  The problem is not all clients of SCM
will want to see a stale version of changed_files.  Also, this change breaks
one of the SCM unit tests for this reason.


More information about the webkit-reviews mailing list