[webkit-reviews] review denied: [Bug 30304] struct RGBA32Buffer is twice as big as the old ImageData of Qt : [Attachment 42028] Follow up patch to move from RGBA32Buffer& frame to RGBA32Buffer* frame and the same for the IntRect

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Holger Freyther <zecke at selfish.org>'s
request for review:
Bug 30304: struct RGBA32Buffer is twice as big as the old ImageData of Qt
https://bugs.webkit.org/show_bug.cgi?id=30304

Attachment 42028: Follow up patch to move from RGBA32Buffer& frame to
RGBA32Buffer* frame and the same for the IntRect
https://bugs.webkit.org/attachment.cgi?id=42028&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
I don't see why rect is non-const to begin with.  If I were writing this code,
I would have written:

const IntRect& rect = m_rects[frameIndex];
in the first place.

this change has been aroudn a while and no one has r+'d it, so I guess I'll
express an opinion and mark it r- as unecessary.  Sorry that you seem to have
stepped into a style land-mine on this bug.  I'm not going to argue with
someone else if they chose to r+ this patch.