[webkit-reviews] review granted: [Bug 32762] upstream platform/chromium/plugins/get-url-with-blank-target.html : [Attachment 45218] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 32762: upstream platform/chromium/plugins/get-url-with-blank-target.html
https://bugs.webkit.org/show_bug.cgi?id=32762

Attachment 45218: Patch
https://bugs.webkit.org/attachment.cgi?id=45218&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
I don't think it makes sense to block upstreaming of Chromium's tests. 
However, i do think it makes sense to have a bug about the differing behavior
between this test and the original.  This bug could serve that purpose.

"behavior. i" seems to be a typo in the ChangeLog.

I think we should probably just land this as-is, and follow-up with a more
informed fix to make Chromium and other WebKit ports agree here.

Lets fix the ChangeLog to note that this behavior difference should be remedied
but for now we're at least testing the behavior.

+var NPERR_GENERIC_ERROR = 1;
line isn't really needed in this edited version of the test, but does no harm.

So I'll r+ this one, but since you're not a committer quiet yet, please post a
new patch which updates the changelog to explain the intent to unify these
behaviors.