[webkit-reviews] review granted: [Bug 32845] [Chromium] WebGL crashes intermittently on Linux : [Attachment 45405] Revised patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Kenneth Russell <kbr at google.com>'s
request for review:
Bug 32845: [Chromium] WebGL crashes intermittently on Linux
https://bugs.webkit.org/show_bug.cgi?id=32845

Attachment 45405: Revised patch
https://bugs.webkit.org/attachment.cgi?id=45405&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
You beat me!  Now my comments are probably mostly obsolete:

A few naming issues.  Some of which the stylebot caught.

We generally try to encouage full names like "display" instead of "dpy"

It's unclear to me if s_initializedGLEW is still needed or if a s_gl check
would be enough now?

I think some folks use sizeof(libnames[0]) in this case:
 319	     for (int i = 0; i < sizeof(libNames) / sizeof(const char*); i++)
Sadly we don't have a template function for that, ojan recently filed a bug
about htat.

I think we should fix the style-bot errors, but otherwise this is ready to
land.  I can't remember if you're a committer yet or not.