[webkit-reviews] review granted: [Bug 32857] RVCT (__ARMCC_VERSION < 400000) does not provide strcasecmp and strncasecmp : [Attachment 45376] Fix the style error.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 22 10:50:09 PST 2009

Darin Adler <darin at apple.com> has granted Kwang Yul Seo
<kwangyul.seo at gmail.com>'s request for review:
Bug 32857: RVCT (__ARMCC_VERSION < 400000) does not provide strcasecmp and

Attachment 45376: Fix the style error.

------- Additional Comments from Darin Adler <darin at apple.com>
This patch is OK, but I'd prefer to see us eliminate strcasecmp and strncasecmp
from the code instead.

These compare non-ASCII characters without any processing, which is better for
our purposes, whereas strcasecmp and strncasecmp may handle non-ASCII
characters as letters based on the current POSIX locale setting.

It'd be good to provide an ASCII version of strcasecmp and strncasecmp and get
rid of the current uses of them.

More information about the webkit-reviews mailing list