[webkit-reviews] review granted: [Bug 32810] Date binding support for Objective-C : [Attachment 45369] Proposed patch (rev.2)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 22 10:35:16 PST 2009

Timothy Hatcher <timothy at hatcher.name> has granted TAMURA, Kent
<tkent at chromium.org>'s request for review:
Bug 32810: Date binding support for Objective-C

Attachment 45369: Proposed patch (rev.2)

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
WOuld making IsPrimitiveType return true for Date give you more of the code
paths you need with out $idlType eq "Date"? Or is IsPrimitiveType used other
places we don't want for Date? Could those be specialcased for Date?

Seems fine though…

More information about the webkit-reviews mailing list