[webkit-reviews] review granted: [Bug 32710] Newlines are drawn as missing-gyphs when using SVG fonts : [Attachment 45383] Fix for newlines turning into missing-gyphs when using SVG fonts

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Tor Arne Vestbø <vestbo at webkit.org>'s
request for review:
Bug 32710: Newlines are drawn as missing-gyphs when using SVG fonts
https://bugs.webkit.org/show_bug.cgi?id=32710

Attachment 45383: Fix for newlines turning into missing-gyphs when using SVG
fonts
https://bugs.webkit.org/attachment.cgi?id=45383&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +	   if (character != space && treatAsSpace(character))
> +	       return space;

The character != space check here seems to be redundant and adds no value. Even
for spaces themselves, I don't think this is faster than just calling
treatAsSpace, which checks for space already. And the most common case is
non-spaces, which get slower due to this check.

> +	   if (character != zeroWidthSpace && treatAsZeroWidthSpace(character))

> +	       return zeroWidthSpace;

Same with the character != zeroWidthSpace check here.

r=me, but I think you should consider removing that extra code