[webkit-reviews] review granted: [Bug 32816] [bzt] Automate the process of calling prepare-ChangeLog : [Attachment 45310] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 21 22:38:39 PST 2009

Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 32816: [bzt] Automate the process of calling prepare-ChangeLog

Attachment 45310: Patch

------- Additional Comments from Eric Seidel <eric at webkit.org>
I think the -o approach is strange, and probably wrong.   $EDITOR or some sort
of user prompting is what we want in the end.

Also --non-interactive makes little sense for PrepareChangeLog, but ok.

The addition of SubmitPatch at this time doesn't seem much value add.  But the
rest of the changes seem great!  (I'm OK keeping it around, just seems kinda
vacuous atm.)

Clearly PostCommits needs to be converted too. :(


More information about the webkit-reviews mailing list