[webkit-reviews] review requested: [Bug 32845] [Chromium] WebGL crashes intermittently on Linux : [Attachment 45362] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has asked  for review:
Bug 32845: [Chromium] WebGL crashes intermittently on Linux
https://bugs.webkit.org/show_bug.cgi?id=32845

Attachment 45362: Patch
https://bugs.webkit.org/attachment.cgi?id=45362&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
The dlclose'ing of libGL.so.1 and dlopen'ing of it each time a
GraphicsContext3D was created was occasionally causing it to be re-mapped at a
different base address. Since GLEW is not re-initialized every time, primarily
for performance reasons, its cached function pointers were pointing to garbage.
Stopped closing and re-opening libGL.so.1 each time; now it is loaded lazily,
when the first 3D context is created. Also reused the X display connection
since the GLX routines' correctness might hinge upon it not resulting in a
change of GL implementation.