[webkit-reviews] review granted: [Bug 32831] Replace UString::Rep implementation, following introduction of ropes to JSC. : [Attachment 45347] Review comment fixage

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 21 13:53:45 PST 2009


Darin Adler <darin at apple.com> has granted Gavin Barraclough
<barraclough at apple.com>'s request for review:
Bug 32831: Replace UString::Rep implementation, following introduction of ropes
to JSC.
https://bugs.webkit.org/show_bug.cgi?id=32831

Attachment 45347: Review comment fixage
https://bugs.webkit.org/attachment.cgi?id=45347&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +	   bool isEmpty() const { return (!m_rep->size()); }

Those parens! Yuck.

r=me


More information about the webkit-reviews mailing list